forked from todogroup/repolinter
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to create Github issue with 'fixers' #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nality Everything works as far as I tested. I still need to add unit tests.
Brend-Smits
changed the title
Add option to create Github issue with 'fixers'
WIP - Add option to create Github issue with 'fixers'
Mar 18, 2021
Setting it via environment variable is slightly counter intuitive, but I was unable to retrieve the target repository in any other way for now. TARGET_REPO example: Brend-Smits/octokit-test-repo or philips-labs/repolinter
issueCreator is now set according to the PAT that is used.
issueCreator is now set according to the PAT that is used.
…-labs/repolinter into feature/github-issue-fix
JeroenKnoops
approved these changes
Mar 22, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
In some cases, labels would not create on target repository.
Brend-Smits
force-pushed
the
feature/github-issue-fix
branch
from
June 20, 2021 15:21
4efbbe0
to
04cd379
Compare
Brend-Smits
force-pushed
the
feature/github-issue-fix
branch
from
June 28, 2021 15:19
ee3312e
to
91bfa50
Compare
Brend-Smits
force-pushed
the
feature/github-issue-fix
branch
from
June 28, 2021 15:36
b711189
to
0d45fda
Compare
Brend-Smits
changed the title
WIP - Add option to create Github issue with 'fixers'
Add option to create Github issue with 'fixers'
Jun 28, 2021
JeroenKnoops
approved these changes
Jun 29, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We want to be able to 'fix' a broken rule and be able to configure it per rule what should happen. For some rules, a notification should be sent, others a Github Issue should be created, some should even create a PR.
This Pull Request adds the ability to define a fix that will create a customizable issue on a target repository.
This currently includes:
To-do
I've temporarily resolved this by allowing you to set a TARGET_REPO environment variable. This is not ideal, but I was unable to retrieve the Git URL from somewhere else.
Test Plan
export GITHUB_TOKEN=TOKENHERE
export TARGET_REPO=brend-smits/octo-test-repo
./bin/repolinter.js -g https://github.com/Brend-Smits/octokit-test-repo --rulesetFile ruleset.json
or execute it on your own repository with your own ruleset.Feedback is much appreciated, I'm not very proficient with Javascript and honestly not amused with the lack of types, classes, and interfaces 🙄