Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: move customizations.vscode.settings to the correct level #329

Merged
merged 1 commit into from
Feb 28, 2024

Conversation

rjaegers
Copy link
Member

@rjaegers rjaegers commented Feb 27, 2024

Pull Request

Description of changes

The JSON property customizations.vscode.settings was rooted under customizations instead of under customizations.vscode. This PR fixes that mistake.

Fixes #317

Checklist

  • I have followed the contribution guidelines for this repository
  • I have added tests for new behavior, and have not broken any existing tests
  • I have added or updated relevant documentation
  • I have verified that all added components are accounted for in the SBOM

Fixes VS Code Settings not taken over from metadata in image label #317
@rjaegers rjaegers requested a review from a team as a code owner February 27, 2024 20:04
Copy link
Contributor

github-actions bot commented Feb 27, 2024

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ ACTION actionlint 14 0 0.06s
✅ DOCKERFILE hadolint 1 0 0.31s
✅ JSON eslint-plugin-jsonc 8 0 0 3.41s
✅ JSON prettier 8 0 0 0.52s
✅ JSON v8r 8 0 4.06s
✅ MARKDOWN markdownlint 8 0 0 1.37s
✅ MARKDOWN markdown-link-check 8 0 8.89s
✅ MARKDOWN markdown-table-formatter 8 0 0 0.25s
✅ REPOSITORY checkov yes no 15.75s
✅ REPOSITORY gitleaks yes no 0.88s
✅ REPOSITORY git_diff yes no 0.0s
✅ REPOSITORY grype yes no 11.42s
✅ REPOSITORY secretlint yes no 1.42s
✅ REPOSITORY trivy yes no 8.51s
✅ REPOSITORY trivy-sbom yes no 1.92s
✅ REPOSITORY trufflehog yes no 6.58s
✅ SPELL lychee 43 0 0.76s
✅ YAML prettier 17 0 0 1.37s
✅ YAML v8r 17 0 13.62s
✅ YAML yamllint 17 0 0.95s

See detailed report in MegaLinter reports

MegaLinter is graciously provided by OX Security

Copy link
Contributor

Compressed layer size comparison

Comparing ghcr.io/philips-software/amp-devcontainer:latest to ghcr.io/philips-software/amp-devcontainer@sha256:4a79568429e814c5a4109c70bfe120855f5ec90d6c48930e0b6a3dbeafde0ef1

OS/Platform Previous Size Current Size Delta
linux/amd64 594.66M 594.70M 40.01K (+0.01%)
linux/arm64 571.86M 571.90M 40.25K (+0.01%)

Copy link
Contributor

Test Results

20 tests  ±0   20 ✅ ±0   40s ⏱️ -2s
 1 suites ±0    0 💤 ±0 
 1 files   ±0    0 ❌ ±0 

Results for commit cf4f613. ± Comparison against base commit 4a45cef.

@rjaegers rjaegers added this pull request to the merge queue Feb 28, 2024
Merged via the queue into main with commit 87af97f Feb 28, 2024
19 checks passed
@rjaegers rjaegers deleted the feature/update-vscode-settings-metadata branch February 28, 2024 08:35
Copy link
Contributor

Pull Request Report (#329)

Static measures

Description Value
Number of added lines 13
Number of deleted lines 13
Number of changed files 1
Number of commits 1
Number of reviews 1
Number of comments (w/o review comments) 3
Number of reviews that contains a comment to resolve 0
Number of reviews that requested a change from the author 0
Number of reviews that approved the Pull Request 1
Get the total number of participants of a Pull Request 3

Time related measures

Description Value
PR lead time (from creation to close of PR) 12.5 Hours
Time that was spend on the branch before the PR was created 2.9 Min
Time that was spend on the branch before the PR was merged 12.6 Hours
Time to merge after last review 14.3 Min

Status check related measures

Description Value
Total runtime for last status check run (Workflow for PR) 24.3 Min
Total time spend in last status check run on PR 16.1 Min

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

VS Code Settings not taken over from metadata in image label
2 participants