Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add cpm package manager to amp-devcontainer-cpp #609

Open
wants to merge 5 commits into from

Conversation

rjaegers
Copy link
Member

@rjaegers rjaegers commented Oct 19, 2024

Pull Request

Description of changes

This PR adds support for the CPM package manager to amp-devcontainer-cpp.

See this roundup for a comparison of C++ package managers.

Warning

This is a convenience function to have an up-to-date CPM available in the CMake Modules directory.

Using it will break when using the same CMakeLists.txt outside of this devcontainer, unless CPM is installed in the local CMake Modules directory as well.

When wanting to guarantee compatibility use an installation method as described on the CPM.cmake page.

Checklist

  • I have followed the contribution guidelines for this repository
  • I have added tests for new behavior, and have not broken any existing tests
  • I have added or updated relevant documentation
  • I have verified that all added components are accounted for in the SBOM

@rjaegers rjaegers requested a review from a team as a code owner October 19, 2024 14:58
Copy link
Contributor

github-actions bot commented Oct 19, 2024

Compressed layer size comparison

Comparing ghcr.io/philips-software/amp-devcontainer-rust:latest to ghcr.io/philips-software/amp-devcontainer-rust@sha256:adbaeced1a630252a328483e31e820c110241083925e0d27c1d4bc8fb744849a

OS/Platform Previous Size Current Size Delta
linux/amd64 425.13M 433.00M 7.87M (+1.85%)
linux/arm64 564.77M 572.52M 7.75M (+1.37%)

Copy link
Contributor

github-actions bot commented Oct 19, 2024

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ ACTION actionlint 16 0 0.11s
✅ DOCKERFILE hadolint 2 0 0.56s
✅ GHERKIN gherkin-lint 2 0 0.69s
✅ JSON npm-package-json-lint yes no 0.52s
✅ JSON prettier 15 2 0 0.66s
✅ JSON v8r 14 0 18.63s
✅ MARKDOWN markdownlint 8 0 0 0.93s
✅ MARKDOWN markdown-table-formatter 8 0 0 0.24s
✅ REPOSITORY checkov yes no 14.59s
✅ REPOSITORY gitleaks yes no 0.39s
✅ REPOSITORY git_diff yes no 0.01s
✅ REPOSITORY grype yes no 12.8s
✅ REPOSITORY secretlint yes no 1.28s
✅ REPOSITORY syft yes no 0.5s
✅ REPOSITORY trivy yes no 5.33s
✅ REPOSITORY trivy-sbom yes no 0.09s
✅ REPOSITORY trufflehog yes no 2.43s
✅ SPELL lychee 56 0 1.52s
✅ YAML prettier 21 0 0 0.93s
✅ YAML v8r 21 0 18.15s
✅ YAML yamllint 21 0 0.47s

See detailed report in MegaLinter reports

You could have the same capabilities but better runtime performances if you use a MegaLinter flavor:

MegaLinter is graciously provided by OX Security

Copy link
Contributor

github-actions bot commented Oct 19, 2024

Test Results

 2 files  ±0   2 suites  ±0   59s ⏱️ +6s
27 tests +1  27 ✅ +1  0 💤 ±0  0 ❌ ±0 
29 runs  +1  29 ✅ +1  0 💤 ±0  0 ❌ ±0 

Results for commit 3b2ee82. ± Comparison against base commit 94025e9.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Oct 19, 2024

Compressed layer size comparison

Comparing ghcr.io/philips-software/amp-devcontainer-cpp:latest to ghcr.io/philips-software/amp-devcontainer-cpp@sha256:478d94b3465f8d5759794461da9e9369e83314663ea688cee81b916923eee595

OS/Platform Previous Size Current Size Delta
linux/amd64 645.35M 645.36M 10.57K (+0.00%)
linux/arm64 638.06M 638.07M 11.03K (+0.00%)

@rjaegers rjaegers added this pull request to the merge queue Oct 21, 2024
Any commits made after this event will not be merged.
@rjaegers rjaegers removed this pull request from the merge queue due to a manual request Oct 21, 2024
Copy link

sonarcloud bot commented Oct 21, 2024

@rjaegers rjaegers added this pull request to the merge queue Oct 21, 2024
Any commits made after this event will not be merged.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants