Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix use-cross when false #9

Merged
merged 1 commit into from
Oct 27, 2023
Merged

Conversation

grzuy
Copy link
Contributor

@grzuy grzuy commented Oct 27, 2023

Second attempt at fixing this after #8 getting reverted.

I think it might be happening that use-cross is getting evaluated to "false" instead of false?

@philss
Copy link
Owner

philss commented Oct 27, 2023

Oh, this actually make a lot of sense! I'm going to merge and I ask you to try pointing to the main branch instead of I releasing a new version, OK?

@philss philss merged commit 5f62155 into philss:main Oct 27, 2023
@philss
Copy link
Owner

philss commented Oct 27, 2023

@grzuy and thank you! 💜

@grzuy grzuy deleted the fix-use-cross-default branch October 27, 2023 23:12
@grzuy
Copy link
Contributor Author

grzuy commented Oct 30, 2023

Unfortunately this didn't fix it for me... https://github.com/mimiquate/candlex/actions/runs/6673124578/job/18138206947.

🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants