Only use proxy if it is valid #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philss
approved these changes
Jul 18, 2022
w0rd-driven
added a commit
to w0rd-driven/rustler_precompiled
that referenced
this pull request
Dec 9, 2022
The change introduced in philss#24 could also be applied to HTTP_PROXY. My system has both variables set to "" , and neither get parsed by `URI.parse` into something usable.
w0rd-driven
added a commit
to w0rd-driven/rustler_precompiled
that referenced
this pull request
Dec 9, 2022
The change introduced in philss#24 could also be applied to the HTTP_PROXY environment variables.
philss
pushed a commit
that referenced
this pull request
Dec 10, 2022
The change introduced in #24 could also be applied to the HTTP_PROXY environment variables.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.