Add support for variants targets #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is needed in order to load the correct variants and building the list of artifacts for download.
This makes the mix task know that needs to download the variants as well.
philss
added a commit
to philss/rustler-precompiled-action
that referenced
this pull request
Sep 15, 2023
This is part of philss/rustler_precompiled#61
|
@josevalim would you mind to take a look? :) |
josevalim
reviewed
Sep 18, 2023
josevalim
reviewed
Sep 18, 2023
lib/rustler_precompiled.ex
Outdated
Comment on lines
315
to
323
| variants = | ||
| maybe_variants_tar_gz_urls( | ||
| metadata[:variants], | ||
| base_url, | ||
| target_triple, | ||
| metadata[:lib_name] | ||
| ) | ||
|
|
||
| [tar_gz_file_url(base_url, file_name) | variants] |
There was a problem hiding this comment.
Maybe worth encapsulating inside a tar_gz_urls function since it is defined both here and above.
There was a problem hiding this comment.
Nice! I moved to a private function :)
josevalim
approved these changes
Sep 18, 2023
philss
added a commit
to philss/rustler-precompiled-action
that referenced
this pull request
Sep 22, 2023
* Support building with a variant name This is part of philss/rustler_precompiled#61 * Add the "features" option and improve logging * Change the `features` input to `cargo-args` The idea is to have more flexibility, enabling more arguments to be passed. * Add a flag to enable debug mode compilation * Fix term and docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature introduces variants, which are alternative versions that can be configured in compile time to
load a specific precompiled NIF depending on the result of callback functions.
This enables developers to set different versions for the same target, depending on which versions of dependencies the target machine has.
Remember that the callback will always run at compile time, in the machine that is doing the compilation.
This may be enough to fix #59 and elixir-explorer/explorer#590
TODOs