chore: removing some warnings

phmonte · Jun 18, 2024 · 8b9d8c3 · 8b9d8c3
1 parent 56d9920
commit 8b9d8c3
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 10 deletions.
diff --git a/src/Buildalyzer/Buildalyzer.csproj b/src/Buildalyzer/Buildalyzer.csproj
@@ -12,12 +12,10 @@
   </PropertyGroup>
 
   <ItemGroup>
-    <PackageReference Include="Microsoft.CodeAnalysis.CSharp" Version="[4,)" />
-    <PackageReference Include="Microsoft.CodeAnalysis.VisualBasic" Version="[4,)" />
-    <PackageReference Include="Microsoft.Extensions.Logging" Version="6.0.0" />
-    <PackageReference Include="MsBuildPipeLogger.Server" Version="1.1.6" />
     <PackageReference Include="Microsoft.Build" Version="17.0.1" />
     <PackageReference Include="Microsoft.Build.Tasks.Core" Version="17.0.1" />
+    <PackageReference Include="Microsoft.CodeAnalysis.CSharp" Version="[4,)" />
+    <PackageReference Include="Microsoft.CodeAnalysis.VisualBasic" Version="[4,)" />
     <PackageReference Include="Microsoft.Extensions.Logging" Version="6.0.0" />
     <PackageReference Include="MSBuild.StructuredLogger" Version="2.1.815" Aliases="StructuredLogger" />
     <PackageReference Include="MsBuildPipeLogger.Server" Version="1.1.6" />

diff --git a/src/Buildalyzer/Environment/BuildEnvironment.cs b/src/Buildalyzer/Environment/BuildEnvironment.cs
@@ -76,7 +76,7 @@ public BuildEnvironment(
         WorkingDirectory = workingDirectory;
 
         // Check if we've already specified a path to MSBuild
-        string envMsBuildExePath = System.Environment.GetEnvironmentVariable(Environment.EnvironmentVariables.MSBUILD_EXE_PATH);
+        string? envMsBuildExePath = System.Environment.GetEnvironmentVariable(Environment.EnvironmentVariables.MSBUILD_EXE_PATH);
         MsBuildExePath = !string.IsNullOrEmpty(envMsBuildExePath) && File.Exists(envMsBuildExePath)
             ? envMsBuildExePath : msBuildExePath;
         if (string.IsNullOrWhiteSpace(MsBuildExePath) && string.IsNullOrWhiteSpace(dotnetExePath))

diff --git a/src/Buildalyzer/Logging/EventProcessor.cs b/src/Buildalyzer/Logging/EventProcessor.cs
@@ -1,8 +1,4 @@
 extern alias StructuredLogger;
-
-using System;
-using System.Collections.Generic;
-using System.Linq;
 using Microsoft.Build.Framework;
 using Microsoft.Extensions.Logging;
 
@@ -100,7 +96,7 @@ private void ProjectStarted(object sender, ProjectStartedEventArgs e)
 
             // Get the TFM for this project
             // use an empty string if no target framework was found, for example in case of C++ projects with VS >= 2022
-            var tfm = propertiesAndItems?.Properties.TryGet("TargetFrameworkMoniker")?.StringValue
+            string tfm = propertiesAndItems?.Properties.TryGet("TargetFrameworkMoniker")?.StringValue
                 ?? string.Empty;
 
             if (propertiesAndItems != null && propertiesAndItems.Properties != null && propertiesAndItems.Items != null)