Increased the default dotnet info wait time to 10 seconds (#228)

phmonte · Dec 20, 2023 · eb80d20 · eb80d20
1 parent 47160a1
commit eb80d20
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/RELEASE.md b/RELEASE.md
@@ -1,6 +1,7 @@
 # 6.0.2
 
-- Changes how projects are added to the `Workspace` in Buildalyzer.Workspaces to be based on the Solution order, if there is a Solution (#241, thanks @AndreasKim).
+- Changed how projects are added to the `Workspace` in Buildalyzer.Workspaces to be based on the Solution order, if there is a Solution (#241, thanks @AndreasKim).
+- Increased the default timeout for `dotnet --info` calls from 4 seconds to 10 seconds (#228). 
 
 # 6.0.1
 

diff --git a/src/Buildalyzer/Environment/DotnetPathResolver.cs b/src/Buildalyzer/Environment/DotnetPathResolver.cs
@@ -10,6 +10,8 @@ namespace Buildalyzer.Environment
 {
     internal class DotnetPathResolver
     {
+        private const int DefaultDotNetInfoWaitTime = 10000; // 10 seconds
+
         private readonly ILoggerFactory _loggerFactory;
         private readonly ILogger<DotnetPathResolver> _logger;
 
@@ -61,7 +63,7 @@ private List<string> GetInfo(string projectPath, string dotnetExePath)
             {
                 int dotnetInfoWaitTime = int.TryParse(System.Environment.GetEnvironmentVariable(EnvironmentVariables.DOTNET_INFO_WAIT_TIME), out int dotnetInfoWaitTimeParsed)
                     ? dotnetInfoWaitTimeParsed
-                    : 4000;
+                    : DefaultDotNetInfoWaitTime;
                 _logger?.LogInformation($"dotnet --info wait time is {dotnetInfoWaitTime}ms");
                 processRunner.Start();
                 processRunner.WaitForExit(dotnetInfoWaitTime);