Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Microsoft.CodeAnalysis packages to 3.7.0 #155

Merged
merged 1 commit into from
Dec 20, 2020

Conversation

jjonescz
Copy link
Contributor

@jjonescz jjonescz commented Dec 1, 2020

In my project, I want to have:

<PackageReference Include="Buildalyzer.Workspaces" Version="3.1.0" />
<PackageReference Include="Microsoft.AspNetCore.Mvc.Razor.RuntimeCompilation" Version="5.0.0" />

which gives me following version conflict error:

myproject.csproj : error NU1107: Version conflict detected for Microsoft.CodeAnalysis.Common. Install/reference Microsoft.CodeAnalysis.Common 3.7.0 directly to project myproject to resolve this issue. 
myproject.csproj : error NU1107:  myproject -> Microsoft.AspNetCore.Mvc.Razor.RuntimeCompilation 5.0.0 -> Microsoft.CodeAnalysis.Razor 5.0.0 -> Microsoft.CodeAnalysis.Common (>= 3.7.0)
myproject.csproj : error NU1107:  myproject -> Buildalyzer.Workspaces 3.1.0 -> Microsoft.CodeAnalysis.CSharp.Workspaces 3.6.0 -> Microsoft.CodeAnalysis.Common (= 3.6.0).

This PR fixes that issue.

@daveaglick
Copy link
Collaborator

Thanks! Always good to keep dependencies up to date.

FWIW I think your particular problem would also have been solved by installed Microsoft.CodeAnalysis.Common 3.7.0 directly in your project. The error message here is essentially saying "two of your references require different versions and we want you to be the decider by installing the correct one yourself". Thankfully in .NET Core the binding for each of the dependencies is taken care of without requiring binding redirects (usually 😬). Of course, adding the older version of Microsoft.CodeAnalysis.Common as the explicit reference might result in missing methods, etc. though.

In any case, happy to bump the version on my end. I'll probably take it up to 3.8.0 as well.

@daveaglick daveaglick merged commit 87e80fe into phmonte:main Dec 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants