When SolutionFilePath is available set in Workspace Solution #177
Conversation
| return Path.GetFullPath( | ||
| Path.Combine( | ||
| Path.GetDirectoryName(typeof(ProjectAnalyzerExtensionsFixture).Assembly.Location), | ||
| @"..\..\..\..\" + partialPath)); |
There was a problem hiding this comment.
Consider using Directory.GetParent instead, slashes are different in different operating systems.
There was a problem hiding this comment.
I didn't want to change too much, that was existing code refactored into a shared method so I assume it's been working.
There was a problem hiding this comment.
@markrendle thanks, keeping the changes limited makes it easier for me to pull this change in without spending a lot of time I don't have right now reviewing it.
@psfinaki I think you've got a very good point though and at some point soon I'll need to do a little auditing of the code to remove slashes wherever I can. That said, I do think the Path family of APIs normalizes slash characters fairly well across platforms which is why this code worked well enough before.
In any case, good enough to merge and release for now :)
|
Thanks! |
When creating a Workspace from an AnalyzerManager created from a solution file, this change ensures that
CurrentSolution.FilePathis set correctly.There were some failing integration tests but I think they're due to my environment being different.