Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Additional files on GetWorkspace() #231

Merged
merged 4 commits into from
Sep 1, 2023

Conversation

Corniel
Copy link
Contributor

@Corniel Corniel commented Aug 9, 2023

It turned out, that Additional files where not added the ProjectInfo. I created both two tests as a simple implementation. Just let me know if that is sufficient.

@daveaglick
Copy link
Collaborator

Thanks for fixing this! And thanks for the review @psfinaki - that makes it easy for me to merge without too much ceremony. I'll be publishing a new minor with just this change momentarily, and then I'll publish a new major that includes the .NET 6 updates from #234 (that way this change will be available to consumers stuck on older .NET versions).

@daveaglick
Copy link
Collaborator

The failure here is from the Cake build (the test suite currently builds a handful of other open source projects). I actually just removed that entire test fixture since keeping up with the various edge cases for full third-party codebases was too challenging. We've already got a test suite with different project types and should just continue to add to that as needed.

None of this is your problem, just noting it here for future reference :).

@daveaglick daveaglick merged commit 21b6d77 into phmonte:main Sep 1, 2023
4 of 6 checks passed
@Corniel Corniel deleted the additional-files branch September 1, 2023 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants