Support nullable context options #235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You're loaded with work, that is pretty clear. How can I (we) help you? |
|
@Corniel I appreciate the offer of help, and you're not wrong about being loaded :). My inclination is just to go ahead and pull down these PRs and merge them as long as tests pass locally. You've already done the heavy lifting by getting a PR open, and the feedback and involvement you had in #239 was a big help (it's always nice to have another set of eyes). At the end of the day, I just need to find a couple hours to get back here and knock these things out. I do see a little relief on the horizon, so I'm hopeful I'll at least be able to merge the pending PRs and get a release out in the coming weeks. Please do feel free to ping me again if that doesn't happen! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that the
NullableContextOptionswhere not set while creating theCSharpCompilationOptions. With this PR, that should be fixed.