Proposal: represent of CompilerItems and CompilerProperties as dedicated types #245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As with #243, I love where your thinking with these changes but just don't have the bandwidth to bring them in. #247 is a request for a new maintainer(s) and I think it makes sense to let whoever takes over the project decide the direction of open PRs. Thanks for the work, and hopefully we can find a maintainer soon and get this merged. |
Corniel
force-pushed
the
compiler-properties
branch
from
6cfbb6c
to
fb61481
Compare
|
@phmonte I think this one is also ready for review. This one should be easy (I think(. |
phmonte
approved these changes
Mar 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While debugging #244, I noticed that debugging which compiler properties where active was not really clear. So similar to #243, I introduced two dedicated (read-only) types that contain the properties and the items. Potentiality, it can replace the dictionaries in the
AnalyzerResult. That is, obviously a breaking change.Under the hood,
CompilerPropertiesandCompilerItemsCollectionare dictionaries (with case-insensitive keys), but as I think (that can be challenged) having the values without the related key have less value in this case, theTryGet()method returns aKeyValuePairlike struct that combines the two.Let me know what you think.