Define a lightweight struct to represent paths #257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Buildalyzer both has to work on UNIX and Windows bases file systems. To deal with (potential) case sensitivity of paths, It also deals with different directory separator paths. The internal representation of
IOPathuses UNIX's'/', and the.ToString()representation is file system based.My plan is to start using this struct instead of
string's for properties that represent IO Paths. Personally, I'm also a big fan ofSystem.IO.FileInfo, andSystem.IO.DirectoryInfo, hence the methods to convert into one of these. The reason not use them directly has to do with the fact that both types handle equality based on their reference, not the thing the represent on the file system.