Fix hang if build does not start #272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Corniel
reviewed
May 7, 2024
| @@ -170,8 +172,22 @@ public IAnalyzerResults Build(string[] targetFrameworks, BuildEnvironment buildE | |||
| GetEffectiveEnvironmentVariables(buildEnvironment), | |||
| Manager.LoggerFactory)) | |||
| { | |||
| processRunner.Exited += () => | |||
| { | |||
There was a problem hiding this comment.
I'm not sure if there is a convention specified for this, but I prefer a method being assigned here.
There was a problem hiding this comment.
I've changed these event handlers to local functions 👍
|
Thanks for the contribution @slang25 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #271
There are other solutions to this, like running
ReadAllin aThreadorTaskand aborting that. I've also looked at the cancellation token and using that, however it's not being used effectively inReadAlland I don't think there is simple solution asAnonymousPipeLoggerServerdoesn't support cooperative cancellation as far as I can see.There may be a memory leak here with the the two events being subscribed to, not sure if we want to try and engineer a better solution.