chore: removing some warnings #275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Corniel
reviewed
May 27, 2024
| @@ -100,7 +96,7 @@ private void ProjectStarted(object sender, ProjectStartedEventArgs e) | |||
|
|
|||
| // Get the TFM for this project | |||
| // use an empty string if no target framework was found, for example in case of C++ projects with VS >= 2022 | |||
| var tfm = propertiesAndItems?.Properties.TryGet("TargetFrameworkMoniker")?.StringValue | |||
| string tfm = propertiesAndItems?.Properties.TryGet("TargetFrameworkMoniker")?.StringValue | |||
There was a problem hiding this comment.
I thought var was okay now? Or is it this particular line where you want string instead?
There was a problem hiding this comment.
var is ok, I removed the warning in the config editor too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 Pull Request Template
Description
The objective is to clean up the project by resolving most of the warnings, it's a long job, I'm trying to solve it in parts, I've been trying to do it in a single PR for a few days, but apparently it won't be possible, we have too many.
Next steps:
Evaluate other warnings.