Grouped messages #209
Merged
Grouped messages #209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kkohbrok
requested changes
Oct 29, 2024
applogic/src/api/messages.rs
Outdated
|
|
||
| while let Some(conversation_message) = iter.next() { | ||
| let mut timestamp = conversation_message.timestamp(); | ||
| match conversation_message.message() { |
There was a problem hiding this comment.
This should probably be a let Message::Content(content_message) = ... else { ... }.
applogic/src/api/messages.rs
Outdated
| // Keep collecting messages from the same sender | ||
| while let Some(next_message) = iter.peek() { | ||
| let temp_timestamp = next_message.timestamp(); | ||
| match next_message.message() { |
There was a problem hiding this comment.
This should also be a let ... else.
applogic/src/api/messages.rs
Outdated
| let temp_timestamp = next_message.timestamp(); | ||
| match next_message.message() { | ||
| Message::Content(next_content_message) => { | ||
| if next_content_message.sender() == current_sender { |
There was a problem hiding this comment.
If all we do is break in the else branch, I'd prefer to check for the negative and break, before the function continues without opening a new code block.
kkohbrok
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.