Upgrade to latest websock_adapter, handle upgrade failures & report 400 #5621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mtrudel does this match the behavior of cowboy? So its strictly backwards compatible? |
|
Not entirely; Cowboy returns 426 for failed HTTP/1 upgrades, but this is strictly incorrect (426 indicates that the current protocol is unsuitable for upgrading, not that the upgrade itself is incorrect). See RFC9110§15.5.22. Bandit returns a 400 in this case. |
|
💚 💙 💜 💛 ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hot on the heels of phoenixframework/websock_adapter#14, handle upgrade errors and return 400 errors to the client, enabling folks to more easily connect upgrade failures with the client that causes them