Replace phx-feedback-for in favor of used_input?/1 #5713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 5, 2024
Merged
josevalim
reviewed
Feb 5, 2024
| @@ -295,7 +295,7 @@ defmodule <%= @web_namespace %>.CoreComponents do | |||
| def input(%{field: %Phoenix.HTML.FormField{} = field} = assigns) do | |||
| assigns | |||
| |> assign(field: nil, id: assigns.id || field.id) | |||
| |> assign(:errors, Enum.map(field.errors, &translate_error(&1))) | |||
| |> assign(:errors, Enum.map(Phoenix.Component.used_errors(field), &translate_error(&1))) | |||
There was a problem hiding this comment.
In my head we'd include used_errors directly in CoreComponent. I don't think we have a precedent for helper input functions in Phoenix.Component, do we?
josevalim
reviewed
Feb 5, 2024
chrismccord
changed the title
josevalim
reviewed
Feb 6, 2024
Comment on lines
81
to
82
| defp assign_form(socket, %Ecto.Changeset{} = changeset, action) do | ||
| assign(socket, :form, to_form(changeset, action: action)) |
There was a problem hiding this comment.
Suggested change
| defp assign_form(socket, %Ecto.Changeset{} = changeset, action) do | |
| assign(socket, :form, to_form(changeset, action: action)) | |
| defp assign_form(socket, %Ecto.Changeset{} = changeset, opts \\ []) do | |
| assign(socket, :form, to_form(changeset, opts)) |
chrismccord
commented
May 3, 2024
chrismccord
commented
May 3, 2024
SteffenDE
added a commit
that referenced
this pull request
Jun 17, 2024
This reverts commit ed19338.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required releases of
phoenix_htmlAdd form action and consider input changed if action changes phoenix_html#439phoenix_ectoUse to_form :action as changeset action when passed phoenix_ecto#171phoenix_live_viewIntroduce tracking of used and unused inputs with error message filtering phoenix_live_view#3090