Skip to content
This repository has been archived by the owner on Aug 11, 2020. It is now read-only.

Introduces universal windows platform, improvements and bugfixing #1

Merged
merged 4 commits into from
Apr 17, 2015
Merged

Introduces universal windows platform, improvements and bugfixing #1

merged 4 commits into from
Apr 17, 2015

Conversation

vladimir-kotikov
Copy link
Collaborator

This PR is a replacement for wildabeast/BarcodeScanner#230:

  • Adds support for windows platform and shares proxy code between windows8 and windows platforms
  • Adds some minor UI improvements
  • Fixes bug when cancel button crashed application (reported as Windows 8 App crashing after cancel click wildabeast/BarcodeScanner#148)
  • Enables autofocus on supported camera devices
  • Includes winmd source as subproject instead of shipping prebuilt winmd component

@dougestey
Copy link

This is the first PR I've seen for this plugin which builds and runs without errors in the 8.1 (windows) environment on Windows Phone. Unfortunately, I'm still getting a green screen when opening the scanner.

@sgrebnov
Copy link

Tested on Windows 👍

@dougestey
Copy link

Does anyone have this working on Windows Phone 8.1?

@vladimir-kotikov better yet - is it intended to?

TimBarham added a commit that referenced this pull request Apr 17, 2015
Introduces universal windows platform, improvements and bugfixing
@TimBarham TimBarham merged commit 4e5af0c into phonegap:master Apr 17, 2015
@vladimir-kotikov
Copy link
Collaborator Author

Hey @dougestey, just tried again to run on Lumia 1520, all works fine.
I recently saw several issues with MediaCapture API on different devices, maybe this is your case. Could you please try it on another device?

@dougestey
Copy link

@vladimir-kotikov thanks so much for your response - I will build on a Lumia 930 today and get back to you. I believe my issue might be that I'm building for 8.1/windows instead of 8.0/wp.

@dougestey
Copy link

@vladimir-kotikov thanks for the tip. this PR (and now master) does build on the 930 on 8.1/windows. Now I just need to figure out why I can't get it to focus.

@vladimir-kotikov
Copy link
Collaborator Author

@dougestey for diagnosing focus problems - try to put several breakpoints around this line and check if your device support auto/continuous focus modes.

@dougestey
Copy link

@vladimir-kotikov the 930 is passing all of those checks, and I'm able to console.log() the focusSettings object, which reveals that continuous mode is properly set - it's just not working in practice (this is strange since we essentially have the same device.)

Anyway, I was able to create a focus button and manually call focusAsync(), which works, so I'm happy: dougestey@b8fc83b

It seems the MediaCapture API is still a bit buggy, so I am willing to chalk my problems up to that and call it a day: https://marekcodes.wordpress.com/2015/02/23/the-horror-of-the-new-windows-phone-8-1-camera-api/

@angegar
Copy link

angegar commented Apr 22, 2015

I am using the plugin on Windows 8.1 and it seems to have bug. I am able to start the camera to scan but it opens a black screen we the cancel button at the bottom rigth corner. When i click cancel i am able to go back to the previous page but the application crash.

Can someone please help on this issue ?

Thank you in advance

stevengill pushed a commit that referenced this pull request May 27, 2015
timwindsor added a commit to timwindsor/phonegap-plugin-barcodescanner that referenced this pull request Jul 17, 2015
Adds BlackBerry 10 support for scanning
EddyVerbruggen pushed a commit that referenced this pull request Oct 21, 2016
Add iOS support for new codes
EddyVerbruggen pushed a commit that referenced this pull request Dec 3, 2016
Case the Activity gets killed by the OS while it's in the background
EddyVerbruggen pushed a commit that referenced this pull request Dec 3, 2016
Disable openDialog barcodeScanDone animations
@lock
Copy link

lock bot commented Jun 8, 2018

This thread has been automatically locked.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

5 participants