Skip to content
This repository has been archived by the owner on Aug 11, 2020. It is now read-only.

FIXED: iOS orientation and rotation bug. #171

Closed
wants to merge 1 commit into from

Conversation

MikelEiza
Copy link

No description provided.

@mike-eason
Copy link

Do we really need all those new line additions?

@MikelEiza
Copy link
Author

MikelEiza commented Mar 1, 2016

No, not really. I think that they were added automatically by my text
editor. If you want I can send another pull request.

@vash15
Copy link

vash15 commented May 13, 2016

Hi @MikelEiza , I tried your code but the XCode returned an error the first time I opened Barcode Scanner.

*** WebKit discarded an uncaught exception in the webView:decidePolicyForNavigationAction:request:frame:decisionListener: delegate: Cannot remove an observer <CDVSplashScreen 0x124e22d50> for the key path "frame" from <UIView 0x124d37050> because it is not registered as an observer.

I'm using XCode 7.3.1 with cordova-ios 4.1.1

@mestremuten
Copy link

Works great!!!

iOS 9.3.2
cordova-ios 4.1.1
cordova-plugin-barcodescanner 5.0.0
cordova CLI 6.2 and ios-deploy 1.8.3 (no xcode)

That's the only fix that made it work in landscape mode without screwing up my App's viewport.

I think this also should fix this issue: #40

saghul added a commit to saghul/phonegap-plugin-barcodescanner that referenced this pull request Jun 16, 2016
Cleaned up version of
phonegap#171
@daserge
Copy link
Collaborator

daserge commented Jun 16, 2016

Tested on iPad iOS 8.1 and iPhone 6 iOS 9.3.1 - works well.

@owq
Copy link

owq commented Jun 17, 2016

Awesome fix. Thanks so much!
Tested on iPad iOS 9.3.2.

@EddyVerbruggen
Copy link
Collaborator

This fixes the black border in landscape mode but I can't scan a code 128 this way. Rotating to portrait fixes this.

I'm sure this works fine for QR codes but not for 2D barcodes I'm afraid.

Do you guys have similar experience with this change applied?

@EddyVerbruggen
Copy link
Collaborator

Found a way - needs another change. Will test a bit and update the repo.

@EddyVerbruggen
Copy link
Collaborator

Thanks @MikelEiza, I only had to add a little tweak to make 2D barcode scanning work on landscape as well. I had to manually merge it due to the merge conflicts, so closing this. Available in 5.0.1.

@lock
Copy link

lock bot commented Jun 7, 2018

This thread has been automatically locked.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

7 participants