-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Change the .aar from resource-file to lib-file #592
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Thanks @jcesarmobile |
@Slzr how did you fixed it manually? |
You can install from github url for now @macdonst can you do a 7.0.2 release if you have time? |
@Trekkar I'm using ionic but I think is the same thing, just use the corresponding # Remove the android build (if you have it)
> ionic cordova platform rm android
# Install the plugin (if you dont have it)
> ionic cordova plugin add phonegap-plugin-barcodescanner In the # Add your platform again
> ionic cordova platform add android
# And build
> ionic cordova build android that is all I did and works for me, hope was helpful 🍻 |
I published a version 7.0.2 version to NPM. cc: @Slzr @Trekkar |
Thks, works!! |
This thread has been automatically locked. |
I saw a comment that said that using lib-file might fix the cordova-android 7/Cordova 8 issue.
Not sure why we have been using resource-file if the .aar is really a lib-file, maybe because resource-file allows to rename the file?
With lib-file it works, but had to also change the compile name on src/android/barcodescanner.gradle.
Other alternative is to rename the .aar, but I think it's better to keep the name so we can easily know the version we are using.
Fixes #589