Remove support for Symfony <2.7 & allow to install with Symfony 4 #446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Minimal version required for PHP is 5.3.9 to match Symfony 2.7 requirements. Additionally this will allow to install bundle on PHP 7.
|
Ping @stloyd! Your PR looks good to me, and the tests are passing. Could we merge this and create a tag so that people can upgrade to Symfony 4? This is actually one of the most popular Symfony bundles (and 4th most popular that doesn't support Symfony 4 yet). Thanks! |
|
Changes look OK to me too ... but Travis CI isn't testing Symfony 4 version yet (see https://travis-ci.org/php-amqplib/RabbitMqBundle/builds/233522035) so we may need to configure more jobs to be sure that Symfony 4 is working as expected. Thanks! |
|
Awesome! Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minimal version required for PHP is 5.3.9 to match Symfony 2.7 requirements. Additionally this will allow to install bundle on PHP 7.