Add support for Symfony 7 #721
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thx for PR, we should keep it compatible with symfony 5.4 in order to not maintain 2 branches/tags. |
Can you elaborate? I'm not sure I understand what you mean with this. |
|
I mark this PR as ready for review. I tested (with Symfony 7.0 and 6.4):
Everything works. |
mihaileu
approved these changes
Jan 10, 2024
|
Thx for this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
This PR should resolve #720.
I mark this PR as draft, because I want to test some other scenarios and versions.
The main problem with upgrade to Symfony7 was with service container. Symfony 7 removed ContainerAwareInterface.
This interface was deprecated since 6.4
My solution is to pass ServiceContainer with public services via CompilerPass.
IMHO We should migrate to Service Locator(from my test this works too). There is only issue with backward compatibility.
The ServiceLocator implements ContainerInterface from Psr namespace not from Symfony.
The Symfony interface extends from Psr interface
In bundle I did not find any calls to those extra methods, but someone could call one and this break backward compatibility.
@mihaileu if you are interested with migration to ServiceLocator I can prepare another PR.