MetricsTest: fix tests failing on imprecise floats #344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrfnl
force-pushed
the
feature/tests-fix-tests-checking-imprecise-floats
branch
from
25b25fe
to
8f36575
Compare
This solves the following test failures (`master` is currently failing on a number of PHP versions): ``` 1) PhpCoveralls\Tests\Bundle\CoverallsBundle\Entity\MetricsTest::shouldHaveLineCoverageOnConstructionWithCoverage Failed asserting that 66.66666666666666 is identical to 66.66666666666667. /home/runner/work/php-coveralls/php-coveralls/tests/Bundle/CoverallsBundle/Entity/MetricsTest.php:86 phpvfscomposer:///home/runner/work/php-coveralls/php-coveralls/vendor/phpunit/phpunit/phpunit:97 2) PhpCoveralls\Tests\Bundle\CoverallsBundle\Entity\MetricsTest::shouldMergeThatWithEmptyMetrics Failed asserting that 66.66666666666666 is identical to 66.66666666666667. /home/runner/work/php-coveralls/php-coveralls/tests/Bundle/CoverallsBundle/Entity/MetricsTest.php:102 phpvfscomposer:///home/runner/work/php-coveralls/php-coveralls/vendor/phpunit/phpunit/phpunit:97 3) PhpCoveralls\Tests\Bundle\CoverallsBundle\Entity\MetricsTest::shouldMergeThat Failed asserting that 66.66666666666666 is identical to 66.66666666666667. /home/runner/work/php-coveralls/php-coveralls/tests/Bundle/CoverallsBundle/Entity/MetricsTest.php:116 phpvfscomposer:///home/runner/work/php-coveralls/php-coveralls/vendor/phpunit/phpunit/phpunit:97 ``` Note: this adds a polyfill to handle a new PHPUnit assertion. Alternatively, you could choose to add the [PHPUnit Polyfills](https://github.com/Yoast/PHPUnit-Polyfills) as a dependency instead. This would allow to use the _official_ method name from PHPUnit. Refs: * https://floating-point-gui.de/ * https://phpunit.readthedocs.io/en/9.5/assertions.html#assertequalswithdelta * https://github.com/Yoast/PHPUnit-Polyfills
jrfnl
force-pushed
the
feature/tests-fix-tests-checking-imprecise-floats
branch
from
8f36575
to
1f392d8
Compare
|
Rebased without changes to see if I could trigger a CI build. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This solves the following test failures (
masteris currently failing on a number of PHP versions):Note: this adds a polyfill to handle a new PHPUnit assertion. Alternatively, you could choose to add the PHPUnit Polyfills as a dependency instead. This would allow to use the official method name from PHPUnit.
Refs: