base64 encode SNS Header message attribure #1308
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rolandsusans
approved these changes
Jul 12, 2023
|
This solution would not work in cases where there are multiple distinct services using enqueue for cross-service communication via messages because this change would introduce bease64 encoding of messages, but if there are other services using an older version of this library, that can not base64 decode messages, the message consumption would break. |
| @@ -51,7 +51,7 @@ public function send(Destination $destination, Message $message): void | |||
| 'MessageAttributes' => [ | |||
| 'Headers' => [ | |||
| 'DataType' => 'String', | |||
| 'StringValue' => json_encode([$message->getHeaders(), $message->getProperties()]), | |||
| 'StringValue' => base64_encode(json_encode([$message->getHeaders(), $message->getProperties()])), | |||
There was a problem hiding this comment.
Maybe we can leave this without encoding base64 for now (keep changes not breaking).
In the next major release, we can add base64_encode part. 🤔
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1307