Extend Exception from Throwable #207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gsteel
force-pushed
the
exception-should-be-throwable
branch
from
af4d62f
to
2c95f8d
Compare
gsteel
force-pushed
the
exception-should-be-throwable
branch
from
2c95f8d
to
7c4c250
Compare
|
Can the technical BC break be overlooked in this instance? I can't imagine a real-world situation where this would break usage of this lib ?? |
dbu
approved these changes
Jul 11, 2022
There was a problem hiding this comment.
thanks for the PR. i don't think we have to worry about this "BC break", the interface is not supposed to be implemented from outside of this library.
what's more, if it would be possible to have an exception that does not implement Throwable, catching Throwable would not work with those exceptions, which would be problematic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Extends the Exception interface from Throwable
Why?
This stops static analysis from moaning about an invalid catch
Checklist