final fixes

php-opencloud · Jan 30, 2024 · e4fe49c · e4fe49c
1 parent 8eba760
commit e4fe49c
Show file tree

Hide file tree

Showing 6 changed files with 13 additions and 8 deletions.
diff --git a/doc/services/object-store/v1/index.rst b/doc/services/object-store/v1/index.rst
@@ -1,6 +1,11 @@
 Object Store v1
 ===============
 
+Object store (Swift) API Version 1. Swift is a highly available, distributed, eventually consistent object/blob store.
+Organizations can use Swift to store lots of data efficiently, safely, and cheaply.
+
+.. osdoc:: https://docs.openstack.org/api-ref/object-store/
+
 .. toctree::
     :maxdepth: 3
 

diff --git a/samples/ObjectStore/v1/account/read.php b/samples/ObjectStore/v1/account/read.php
@@ -13,3 +13,5 @@
 
 $service = $openstack->objectStoreV1();
 $account = $service->getAccount();
+
+$account->retrieve();
diff --git a/samples/ObjectStore/v1/containers/read.php b/samples/ObjectStore/v1/containers/read.php
@@ -13,4 +13,5 @@
 
 $service = $openstack->objectStoreV1();
 $container = $service->getContainer('{containerName}');
-$container->retrieve();
+
+$container->retrieve();
diff --git a/tests/sample/Networking/v2/NetworkTest.php b/tests/sample/Networking/v2/NetworkTest.php
@@ -53,7 +53,7 @@ public function testUpdate(Network $createdNetwork)
     /**
      * @depends testCreate
      */
-    public function testRetrieve(Network $createdNetwork)
+    public function testRead(Network $createdNetwork)
     {
         /** @var \OpenStack\Networking\v2\Models\Network $network */
         require_once $this->sampleFile('networks/read.php', ['{networkId}' => $createdNetwork->id]);

diff --git a/tests/sample/Networking/v2/PortTest.php b/tests/sample/Networking/v2/PortTest.php
@@ -97,7 +97,7 @@ public function testList(Port $createdPort)
     /**
      * @depends testCreate
      */
-    public function testGet(Port $createdPort)
+    public function testRead(Port $createdPort)
     {
         /** @var $port \OpenStack\Networking\v2\Models\Port */
         require_once $this->sampleFile(
@@ -108,9 +108,6 @@ public function testGet(Port $createdPort)
 
         $this->assertInstanceOf(Port::class, $port);
         $this->assertNotEmpty($port->id);
-        $this->assertEmpty($port->name);
-
-        $port->retrieve();
         $this->assertNotEmpty($port->name);
     }
 

diff --git a/tests/sample/Networking/v2/SubnetTest.php b/tests/sample/Networking/v2/SubnetTest.php
@@ -100,10 +100,10 @@ public function testUpdate(Subnet $createdSubnet)
     /**
      * @depends testCreate
      */
-    public function testRetrieve(Subnet $createdSubnet)
+    public function testRead(Subnet $createdSubnet)
     {
         /** @var $subnet \OpenStack\Networking\v2\Models\Subnet */
-        require_once $this->sampleFile('subnets/get.php', ['{subnetId}' => $createdSubnet->id]);
+        require_once $this->sampleFile('subnets/read.php', ['{subnetId}' => $createdSubnet->id]);
 
         $this->assertInstanceOf(Subnet::class, $subnet);
         $this->assertEquals($subnet->id, $subnet->id);