Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ext/standard/tests/general_functions/proc_nice_basic.phpt only works at certain nice levels #11630

Closed
orlitzky opened this issue Jul 7, 2023 · 0 comments

Comments

@orlitzky
Copy link
Contributor

orlitzky commented Jul 7, 2023

Description

This test tries to bump up the nice level by 5, and then checks that it was bumped by 5:

    $delta = 5;
    $pid = getmypid();
    $niceBefore = getNice($pid);
    proc_nice($delta);
    $niceAfter = getNice($pid);
    var_dump($niceBefore == ($niceAfter - $delta));
--EXPECT--
bool(true)

This is failing on my machine, and I'm pretty sure it's just because I'm already running at a high "nice" level that can't be increased by 5 (the max is 19).

PHP Version

php-8.2.8

Operating System

No response

@nielsdos nielsdos self-assigned this Jul 8, 2023
nielsdos added a commit that referenced this issue Jul 10, 2023
* PHP-8.1:
  Fix GH-11630: proc_nice_basic.phpt only works at certain nice levels
  Fix GH-11629: bug77020.phpt tries to send mail
  Fix GH-11625: DOMElement::replaceWith() doesn't replace node with DOMDocumentFragment but just deletes node or causes wrapping <></> depending on libxml2 version
nielsdos added a commit that referenced this issue Jul 10, 2023
* PHP-8.2:
  Fix GH-11630: proc_nice_basic.phpt only works at certain nice levels
  Fix GH-11629: bug77020.phpt tries to send mail
  Fix GH-11625: DOMElement::replaceWith() doesn't replace node with DOMDocumentFragment but just deletes node or causes wrapping <></> depending on libxml2 version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants