Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug-gh11600.phpt to work with different ICU versions #11684

Merged
merged 1 commit into from
Jul 12, 2023

Conversation

nielsdos
Copy link
Member

No description provided.

@nielsdos nielsdos merged commit 9c47f33 into php:PHP-8.2 Jul 12, 2023
@iluuu1994
Copy link
Member

iluuu1994 commented Jul 12, 2023

Hmm, for some reason it fails still.

 ========DIFF========
     string(%d) "h:mm%sa"
     string(%d) "4:02%sPM"
003+ int(1689177720)
003- int(1689091320)
========DONE========
FAIL Bug GH-11600: Intl patterns are not parseable DateTime Strings [ext/date/tests/bug-gh11600.phpt] 
=====================================================================

@nielsdos
Copy link
Member Author

It worked yesterday night in Ci.
Looking at the fail now: the timestamp is wrong, this timestamp that CI outputs corresponds to 12th of July instead of 11th. Somehow parsing is taking todays date

@iluuu1994
Copy link
Member

/cc @derickr

@iluuu1994
Copy link
Member

@nielsdos Should be fixed now. The formatter just outputs the time, so we need to supply the date.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants