Fix GH-10964: Improve man page about the built-in server
#11857
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fwiw, CI failed because of a deprecation that has been fixed in the meantime, but as you still use a very old 8.1 branch it's still there for you. Although it doesn't matter for this contribution, I think it's a good idea to update your local branches with upstream in case you want to do future contributions. |
alexandre-daubois
force-pushed
the
improve-man-page
branch
from
e8ce622
to
c5cd0a8
Compare
|
Oh yes, I thought I was up-to-date with the upstream. 8.1 is caught-up now 🙂 |
nielsdos
requested changes
Aug 2, 2023
sapi/cli/php.1.in
Outdated
| @@ -92,6 +92,15 @@ point to a local address and port PHP will listen to HTTP requests on that addre | |||
| .B docroot | |||
| passed by the \-t option. | |||
| .LP | |||
| If a PHP file is provided to the command line when the | |||
| built-in web server is used, it will be ued as the router script. This script | |||
| will be started at each HTTP request. The script output will is returned to the | |||
There was a problem hiding this comment.
Suggested change
| will be started at each HTTP request. The script output will is returned to the | |
| will be started at each HTTP request. The script output is returned to the |
There was a problem hiding this comment.
Both comments addressed, thanks! 🙂
sapi/cli/php.1.in
Outdated
| @@ -92,6 +92,15 @@ point to a local address and port PHP will listen to HTTP requests on that addre | |||
| .B docroot | |||
| passed by the \-t option. | |||
| .LP | |||
| If a PHP file is provided to the command line when the | |||
| built-in web server is used, it will be ued as the router script. This script | |||
There was a problem hiding this comment.
Suggested change
| built-in web server is used, it will be ued as the router script. This script | |
| built-in web server is used, it will be used as the router script. This script |
sapi/cli/php.1.in
Outdated
| browser, unless the router script returns the | ||
| .B false | ||
| value. If so, the built-in server falls back to the default behaviour, returning | ||
| the requested resource as-is by looking-up the files relative to the document |
There was a problem hiding this comment.
I think that it should be looking up instead of looking-up.
There was a problem hiding this comment.
Updated, thanks Javier! 😃
alexandre-daubois
force-pushed
the
improve-man-page
branch
from
c5cd0a8
to
fa35dc9
Compare
nielsdos
approved these changes
Aug 3, 2023
jorgsowa
pushed a commit
to jorgsowa/php-src
that referenced
this pull request
Aug 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #10964