Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update JIT nightly config #12662

Merged
merged 1 commit into from
Nov 14, 2023
Merged

Update JIT nightly config #12662

merged 1 commit into from
Nov 14, 2023

Conversation

danog
Copy link
Contributor

@danog danog commented Nov 13, 2023

@danog danog marked this pull request as ready for review November 13, 2023 14:42
@danog danog mentioned this pull request Nov 13, 2023
Draft
dstogov
dstogov approved these changes Nov 13, 2023
View reviewed changes
Copy link
Member

@dstogov dstogov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For now I don't see problems.

If we are going to run community tests on ARM then opcache.jit_buffer_size should be reduced to 128M. This may be done conditionally.

@danog
Copy link
Contributor Author

danog commented Nov 13, 2023

I'll make sure to lower the JIT buffer size in the (eventual) PR that enables nightly tests on ARM!

@danog
Copy link
Contributor Author

danog commented Nov 14, 2023

@dstogov Btw could you or @iluuu1994 or someone else merge this? :)

@dstogov dstogov merged commit 82dcfd1 into php:master Nov 14, 2023
7 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dstogov dstogov dstogov approved these changes

@iluuu1994 iluuu1994 Awaiting requested review from iluuu1994

@TimWolla TimWolla Awaiting requested review from TimWolla TimWolla is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danog @dstogov