Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug #40531 mb_substr optional parameters #13

Closed
wants to merge 3 commits into from
Closed

Fix bug #40531 mb_substr optional parameters #13

wants to merge 3 commits into from

Commits on Mar 20, 2012

  1. Enable a test (for bug #40531) which was skipped

    François Gannaz committed Mar 20, 2012
    Configuration menu
    Copy the full SHA
    1269754 View commit details
    Browse the repository at this point in the history

  2. Allow type check for IS_LONG in zend_verify_arg_type() 

    zend_verify_arg_type() only accepted to verify arg types as classes,
arrays or objects. Now it accepts integers. This is necessary to
check wether an argument is an integer or null, which can't be done
at a higher level like zend_parse_parameters(...,"l").
    François Gannaz committed Mar 20, 2012
    Configuration menu
    Copy the full SHA
    a61c0e9 View commit details
    Browse the repository at this point in the history

  3. Fix bug #40531 mb_substr optional parameters 

    To distinguish between null and 0 for an integer parameter,
we have to use the "z!" type instead of "l" in zend_parse_parameters().
So the type checks are now done in the prototype with
ZEND_ARG_TYPE_INFO().

The prototype is more strict than before. An non integer (or a string
that isn't purely numeric) will lead to a fatal error, whereas there was
previously a simple warning.
    François Gannaz committed Mar 20, 2012
    Configuration menu
    Copy the full SHA
    027284f View commit details
    Browse the repository at this point in the history