Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the MySQL Server version used for testing to 8.3 #14120

Closed
wants to merge 1 commit into from
Closed

Fix the MySQL Server version used for testing to 8.3 #14120

wants to merge 1 commit into from

Conversation

KentarouTakeda
Copy link
Contributor

Refer to #14118

MySQL 8.4 has been released, but some server behavior seems to be unstable. Therefore, we will fix the version of the mysql image used for testing to 8.3.

@KentarouTakeda
Copy link
Contributor Author

Note: MySQL 8.4 is marked as an LTS version. Therefore, it is a good idea to re-pin to 8.4 along with testing on CircleCI as soon as we are sure that the original issue has been resolved. (I will be keeping a close eye on future releases of MySQL for some time)

SakiTakamachi added a commit that referenced this pull request May 3, 2024
@SakiTakamachi
Merge branch 'PHP-8.3'
f442cec 
* PHP-8.3:
  Fix the MySQL Server version used for testing to  (#14120)
@SakiTakamachi
Copy link
Member

Thanks!

SakiTakamachi added a commit to SakiTakamachi/php-src that referenced this pull request May 3, 2024
@SakiTakamachi
Revert "Fix the MySQL Server version used for testing to (php#14120)"
93cb4fa 
This reverts commit febbbfa.
SakiTakamachi added a commit to SakiTakamachi/php-src that referenced this pull request May 3, 2024
@SakiTakamachi
Revert "Fix the MySQL Server version used for testing to (php#14120)"
6f06dad 
This reverts commit febbbfa.
@SakiTakamachi
Copy link
Member

After merging to 8.3, a large number of Oracle tests failed.
However, this happened to be due to the release of a new libclntshcore.so.23.1 and was unrelated to this PR.

@SakiTakamachi SakiTakamachi mentioned this pull request May 4, 2024
Closed
@KentarouTakeda
Copy link
Contributor Author

NOTE:

MySQL 8.4.1 has been released.

However, the fix for the mysql_native_password bug that was temporarily circumvented in this pull request was not included in the 8.4.1 release notes.

We should continue to use 8.3. I will continue to monitor MySQL releases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SakiTakamachi SakiTakamachi SakiTakamachi approved these changes

@iluuu1994 iluuu1994 Awaiting requested review from iluuu1994

@TimWolla TimWolla Awaiting requested review from TimWolla TimWolla is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KentarouTakeda @SakiTakamachi