ext/pgsql: adding pg_close_stmt. #14584
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petk
reviewed
Jun 21, 2024
ext/pgsql/config.m4
Outdated
| @@ -71,6 +71,7 @@ if test "$PHP_PGSQL" != "no"; then | |||
| AC_CHECK_LIB(pq, PQchangePassword, AC_DEFINE(HAVE_PG_CHANGE_PASSWORD,1,[PostgreSQL 17 or later])) | |||
| AC_CHECK_LIB(pq, PQsocketPoll, AC_DEFINE(HAVE_PG_SOCKET_POLL,1,[PostgreSQL 17 or later])) | |||
| AC_CHECK_LIB(pq, PQsetChunkedRowsMode, AC_DEFINE(HAVE_PG_SET_CHUNKED_ROWS_SIZE,1,[PostgreSQL 17 or later])) | |||
| AC_CHECK_LIB(pq, PQclosePrepared, AC_DEFINE(HAVE_PG_CLOSE_STMT,1,[PostgreSQL 17 or later])) | |||
There was a problem hiding this comment.
Here, now you just need to do rebase against the master branch and check it like this:
PHP_CHECK_LIBRARY([pq], [PQclosePrepared],
[AC_DEFINE([HAVE_PG_CLOSE_STMT], [1], [PostgreSQL 17 or later])],,
[$PGSQL_LIBS])There was a problem hiding this comment.
cool. I ll even wait your libpq bump merged.
kocsismate
reviewed
Jun 21, 2024
ext/pgsql/pgsql.stub.php
Outdated
| @@ -974,6 +974,9 @@ function pg_socket_poll($socket, int $read, int $write, int $timeout = -1): int | |||
| #ifdef HAVE_PG_SET_CHUNKED_ROWS_SIZE | |||
| function pg_set_chunked_rows_size(Pgsql\Connection $connection, int $size): bool {} | |||
| #endif | |||
| #ifdef HAVE_PG_CLOSE_STMT | |||
| function pg_close_stmt(Pgsql\Connection $connection, string $stmt_name): Pgsql\Result|false {} | |||
There was a problem hiding this comment.
$statement_name is the consistent param name with the existing params.
Suggested change
| function pg_close_stmt(Pgsql\Connection $connection, string $stmt_name): Pgsql\Result|false {} | |
| function pg_close_stmt(Pgsql\Connection $connection, string $statement_name): Pgsql\Result|false {} |
devnexen
force-pushed
the
pg_close_prepared
branch
2 times, most recently
from
edb0556
to
cde1c80
Compare
devnexen
force-pushed
the
pg_close_prepared
branch
from
cde1c80
to
4419d1b
Compare
Girgias
reviewed
Sep 29, 2024
ext/pgsql/pgsql.c
Outdated
Comment on lines
6283
to
6285
| if (!pgsql_result) { | ||
| RETURN_FALSE; | ||
| } else { |
There was a problem hiding this comment.
Possibly?
Suggested change
| if (!pgsql_result) { | |
| RETURN_FALSE; | |
| } else { | |
| if (pgsql_result != PGRES_COMMAND_OK) { | |
| RETURN_FALSE; | |
| } else { |
ext/pgsql/pgsql.c
Outdated
| if (!pgsql_result) { | ||
| RETURN_FALSE; | ||
| } else { | ||
| pgsql_result_handle *pg_result; |
up to postgresql 17, when done with a prepared statement, we could release it with DEALLOCATE sql command which is fine ; until we want to implement a cache solution based on statement ids. Since PostgreSQL 17, PQclosePrepared uses internally the `close` protocol allowing to reuse the statement name while still freeing it. Since the close protocol implementation had been added on libpq within this release, no way to reimplement it.
devnexen
force-pushed
the
pg_close_prepared
branch
from
4419d1b
to
0d3bb58
Compare
Girgias
approved these changes
Sep 29, 2024
jorgsowa
pushed a commit
to jorgsowa/php-src
that referenced
this pull request
Oct 1, 2024
up to postgresql 17, when done with a prepared statement, we could release it with DEALLOCATE sql command which is fine ; until we want to implement a cache solution based on statement ids. Since PostgreSQL 17, PQclosePrepared uses internally the `close` protocol allowing to reuse the statement name while still freeing it. Since the close protocol implementation had been added on libpq within this release, no way to reimplement it. close phpGH-14584
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
up to postgresql 17, when done with a prepared statement, we could release it with DEALLOCATE sql command which is fine ; until we want to implement a cache solution based on statement ids.
Since PostgreSQL 17, PQclosePrepared uses internally the
closeprotocol allowing to reuse the statement name while still freeing it. Since the close protocol implementation had been added on libpq within this release, no way to reimplement it.