Fix pdoodbc_002.phpt to not try to load PDO_odbc #16096
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the `--EXTENSIONS--` section, names of extension are handled case- sensitively.
jorgsowa
pushed a commit
to jorgsowa/php-src
that referenced
this pull request
Oct 1, 2024
In the `--EXTENSIONS--` section, names of extension are handled case- sensitively.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the
--EXTENSIONS--section, names of extension are handled case- sensitively.I was pretty confused when I saw https://github.com/php/php-src/actions/runs/11082846756/job/30796380227?pr=16089#step:6:148; but it's pretty clear what's going: if the extension is already loaded, the test runner still tries to load
PDO_odbcwhat even works with a case-insensitive file system. For case-sensitive file system, there likely would be an error about failing to load the extension.