Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci skip] Update EXTENSIONS and CODEOWNERS for ext/soap #16542

Merged
merged 1 commit into from
Oct 22, 2024

Conversation

nielsdos
Copy link
Member

De facto, I do the maintenance. But since many bugs are blocked by not having reproducers and there's some fundamental issues in the extension, this should get the "odd fixes" status instead. The "odd fixes" description should perhaps also be updated to include a statement about "limited willpower to debug"...

De facto, I do the maintenance. But since many bugs are blocked by not
having reproducers and there's some fundamental issues in the extension,
this should get the "odd fixes" status instead. The "odd fixes"
description should perhaps also be updated to include a statement about
"limited willpower to debug"...
@cmb69
Copy link
Member

cmb69 commented Oct 21, 2024

I'm glad that you want officially to be code owner of ext/soap, but I don't think it makes sense to keep EXTENSIONS at all. It was okay before we added CODEOWNERS, but it is grossly out-dated, and doesn't serve any particular purpose. I mean what would maintenance "obsolete" even mean? Or status "not working"?

@nielsdos
Copy link
Member Author

Those aspects are strange indeed. I was told the EXTENSIONS file offers some history which is why it is kept.

Copy link
Member

@cmb69 cmb69 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, there is the Cleaning up unmaintained extensions RFC which makes EXTENSIONS an "official document". So we probably need to keep it.

@nielsdos nielsdos merged commit 5c21042 into php:PHP-8.2 Oct 22, 2024
2 checks passed
nielsdos added a commit that referenced this pull request Oct 22, 2024
* PHP-8.2:
  [ci skip] Update EXTENSIONS and CODEOWNERS for ext/soap (#16542)
nielsdos added a commit that referenced this pull request Oct 22, 2024
* PHP-8.3:
  [ci skip] Update EXTENSIONS and CODEOWNERS for ext/soap (#16542)
nielsdos added a commit that referenced this pull request Oct 22, 2024
* PHP-8.4:
  [ci skip] Update EXTENSIONS and CODEOWNERS for ext/soap (#16542)
  [ci skip] Update NEWS for PHP 8.4.0RC4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants