Improve building the LDAP and OCI8 extensions statically. #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows the LDAP extension to link with the Oracle Instant Client ZIP file library LDAP implementation, e.g. using --with-ldap=/path/to/instantclient. (Does not support building with Instant Client RPMS.) Allows the LDAP and OCI8 extensions to be statically built when not passing a directory to --with-ldap. However this uses Oracle ldap.h headers but doesn't use Oracle's LDAP implementation. A preferred user build scenario is to build PHP without OCI8, and then build OCI8 as a shared extension.
|
@cjbj So what's up with this patch - is it finished? Does it need changes? |
|
If you're OK with the patch in principle, I'll update the patch to include Oracle 12 and will merge it directly to git.php |
|
Once HAVE_ORALDAP_11 is introduced then ext/ldap/ldap.c must be fixed as well, otherwise many ldap_* functions becomes unavailable. I will post a patch here later. |
|
I merged a variation of the patch directly to git.php.net |
|
For future reference, the commit SHA1 is 5bc3774 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows the LDAP extension to link with the Oracle Instant Client ZIP
file library LDAP implementation, e.g. using
--with-ldap=/path/to/instantclient. (Does not support building with
Instant Client RPMS.)
Allows the LDAP and OCI8 extensions to be statically built when not
passing a directory to --with-ldap. However this uses Oracle ldap.h
headers but doesn't use Oracle's LDAP implementation. A preferred
user build scenario is to build PHP without OCI8, and then build OCI8
as a shared extension.