op2 is already declared #2595
Closed
op2 is already declared #2595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
zend_vm_execute.c is a generated file. The change needs to be done in zend_vm_def.h and then Zend/zend_vm_gen.php should be called to regenerate the VM. I'd also suggest fixing this the other way around, so that free_op2 and op2 stay together. |
tvlooy
force-pushed
the
op2_already_declared
branch
from
fb61c99
to
a33cb11
Compare
|
@nikic I didn't know that. Thanks for your help |
|
Merged as 60d032d, thanks :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed this warning while compiling:
Zend/zend_vm_execute.h:1328:15: warning: unused variable ‘op2’ [-Wunused-variable]op2 is first declared on line 1328 but I suggest keeping that one because it is in the top with the other declarations, and remove the second declaration instead