Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

op2 is already declared #2595

Closed
wants to merge 1 commit into from
Closed

Conversation

tvlooy
Copy link
Contributor

@tvlooy tvlooy commented Jun 25, 2017

I noticed this warning while compiling:
Zend/zend_vm_execute.h:1328:15: warning: unused variable ‘op2’ [-Wunused-variable]

op2 is first declared on line 1328 but I suggest keeping that one because it is in the top with the other declarations, and remove the second declaration instead

@nikic
Copy link
Member

nikic commented Jun 25, 2017

zend_vm_execute.c is a generated file. The change needs to be done in zend_vm_def.h and then Zend/zend_vm_gen.php should be called to regenerate the VM.

I'd also suggest fixing this the other way around, so that free_op2 and op2 stay together.

@tvlooy
Copy link
Contributor Author

tvlooy commented Jun 25, 2017

@nikic I didn't know that. Thanks for your help

@nikic
Copy link
Member

nikic commented Jun 25, 2017

Merged as 60d032d, thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants