-
Notifications
You must be signed in to change notification settings - Fork 7.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PowerPC64 support in safe_address function #919
PowerPC64 support in safe_address function #919
Conversation
@remicollet, @smalyshev, @datibbaw, @laruence: the PR #734 has been rebased in this one. |
Tried against master on
This make ext/spl/tests/bug67247.phpt segfault: Without the patch
With:
|
FYI, we now have 0 failed tests on ppc64, so testing will be easier (build with --disable-all, so no extension tested) |
@remicollet, thank you very much :) |
Any update on this one ? (still segfault) |
Sorry @remicollet, not yet, I and my teammates (@caioso, @lbianc) we're still checking. |
@gustavotemple no urgency ;) |
Add a ppc64-specific implementation of the safe_address function with overflow checking.
@remicollet, done, fixed. |
Tested on
No regression detected. Fine :) |
Comment on behalf of remi at php.net: merged, thanks for improving PHP on PowerPC :) |
Add a ppc64-specific implementation of the safe_address
function with overflow checking.