Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The executable files should be merged into a single executable file #517

Closed
MauricioFauth opened this issue Oct 6, 2023 · 2 comments · Fixed by #594
Closed

The executable files should be merged into a single executable file #517

MauricioFauth opened this issue Oct 6, 2023 · 2 comments · Fixed by #594
Assignees
@MauricioFauth
Labels
enhancement help wanted
Milestone
6.0.0

Comments

@MauricioFauth
Copy link
Member

This library currently ships with three executable files: highlight-query, lint-query and tokenize-query.

I propose that the three files should be combined into a single executable file called sql-parser.

-lint-query --query "SELECT 1"
+sql-parser --query "SELECT 1"
-lint-query --query "SELECT 1"
+sql-parser --lint --query "SELECT 1"
-highlight-query --query "SELECT 1"
+sql-parser --highlight --query "SELECT 1"
-tokenize-query --query "SELECT 1"
+sql-parser --tokenize --query "SELECT 1"

I think that highlight-query, lint-query and tokenize-query should be removed only in version 7.0.0.
@williamdes
Copy link
Member

I'd say in 6.0?

MauricioFauth added a commit to MauricioFauth/sql-parser that referenced this issue Jan 17, 2024
@MauricioFauth
Add bin/sql-parser executable file
38959b6 
- Related to phpmyadmin#517

Signed-off-by: Maurício Meneghini Fauth <[email protected]>
@MauricioFauth MauricioFauth mentioned this issue Jan 17, 2024
Merged
MauricioFauth added a commit to MauricioFauth/sql-parser that referenced this issue Jan 18, 2024
@MauricioFauth
Add bin/sql-parser executable file
bb01d8a 
- Related to phpmyadmin#517

Signed-off-by: Maurício Meneghini Fauth <[email protected]>
@niconoe-
Copy link
Contributor

AFAIK, this is done and is working like a charm.

Is there something else to do before closing this issue?

@MauricioFauth MauricioFauth mentioned this issue Oct 25, 2024
Merged
@MauricioFauth MauricioFauth added this to the 6.0.0 milestone Nov 10, 2024
@MauricioFauth MauricioFauth self-assigned this Nov 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MauricioFauth MauricioFauth

Labels
enhancement help wanted
Projects
None yet
Milestone
6.0.0
Development

Successfully merging a pull request may close this issue.

Remove alternative executable files MauricioFauth/sql-parser
3 participants
@MauricioFauth @williamdes @niconoe-