Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add partial support for assertContainsOnlyInstancesOf #180

Merged
merged 1 commit into from
Jul 20, 2023

Conversation

villfa
Copy link
Contributor

@villfa villfa commented May 2, 2023

Add support for assertContainsOnlyInstancesOf when the 2nd argument is an array.
The behaviour is not changed when it is an instance of Traversable.

See #158

@villfa villfa marked this pull request as draft May 2, 2023 10:26
@villfa
Copy link
Contributor Author

villfa commented May 2, 2023

I move this PR back to draft since I forgot to consider the argument could be an instance of Traversable...
EDIT: I've added a test to be sure there is no regression when the 2nd argument is an instance of Traversable, in order to make this PR ready to be reviewed.

@villfa villfa force-pushed the feat/contains-only-instanceof branch from cbae561 to d29fb8b Compare May 2, 2023 12:30
@villfa villfa changed the title Add support for assertContainsOnlyInstancesOf Add partial support for assertContainsOnlyInstancesOf May 2, 2023
@villfa villfa marked this pull request as ready for review May 2, 2023 12:32
@ondrejmirtes ondrejmirtes merged commit 87df766 into phpstan:1.1.x Jul 20, 2023
@ondrejmirtes
Copy link
Member

Thank you.

@villfa villfa deleted the feat/contains-only-instanceof branch July 20, 2023 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants