Expand AssertSameWithCountRule to support sizeof #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ondrejmirtes
requested changes
Jan 1, 2018
| return [ | ||
| 'You should use assertCount($expectedCount, $variable) instead of assertSame($expectedCount, count($variable)).', | ||
| ]; | ||
| $method = strtolower($right->name->toString()); |
There was a problem hiding this comment.
It's not a method, it's a functionName.
|
|
||
| if ($method === 'count') { | ||
| return [ | ||
| sprintf($message, 'count'), |
There was a problem hiding this comment.
What about sprintf($message, $method) instead of this if/else?
There was a problem hiding this comment.
Shouldn’t we verify if the function is count or sizeof? I followed the if that was here 😁
There was a problem hiding this comment.
OK, just try to simplify the code somehow :)
carusogabriel
commented
Jan 1, 2018
| @@ -36,10 +36,13 @@ public function processNode(Node $node, Scope $scope): array | |||
| if ( | |||
| $right instanceof Node\Expr\FuncCall | |||
| && $right->name instanceof Node\Name | |||
| && strtolower($right->name->toString()) === 'count' | |||
| && in_array(strtolower($right->name->toString()), ['count', 'sizeof']) | |||
There was a problem hiding this comment.
@ondrejmirtes Should I assigned the functionName inside the if, or is fine to repeat strtolower($right->name->toString()?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As suggested in #7, I've expand
AssertSameWithCountRuleto supportcount's alias:sizeof👍