Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support ANSI-escaped color codes and hyperlinks. #106

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

psftw
Copy link

@psftw psftw commented May 28, 2019

No description provided.

@psftw
Copy link
Author

psftw commented May 28, 2019

Thanks for creating this library. I'm using it in a CLI application, and supporting properly aligned clickable hyperlinks in the output is a really handy feature for my use case.

@codecov
Copy link

codecov bot commented May 28, 2019

Codecov Report

Merging #106 into master will increase coverage by 0.41%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #106      +/-   ##
==========================================
+ Coverage   85.86%   86.28%   +0.41%     
==========================================
  Files           5        5              
  Lines        1323     1327       +4     
==========================================
+ Hits         1136     1145       +9     
+ Misses        187      182       -5
Impacted Files Coverage Δ
src/utils.rs 99.13% <100%> (+4.49%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf7dca3...7b32d22. Read the comment docs.

@phsym phsym self-requested a review August 25, 2019 12:15
@phsym phsym added this to the V0.9.0 milestone Aug 25, 2019
Copy link
Owner

@phsym phsym left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you ! I didn't know about hypertext. Could you please rebase your changes and fix those conflicts ?

By the way, sorry for the late reply. The beginning of the year was a very busy one for me.

@psftw
Copy link
Author

psftw commented Oct 4, 2019

Rebased 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants