Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creation of prettytable-rs-derive and the creation of table from vector #115

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

thymbahutymba
Copy link

Pull request referring to the issue #109

Sorry for the mess that I've made trying to improve the TableElem method removing &self from get_field_name
The code is already rebased. This should be a kind of final code which is the results of the previous commit and pull request #110

@codecov
Copy link

codecov bot commented Aug 27, 2019

Codecov Report

Merging #115 into master will increase coverage by 0.29%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #115      +/-   ##
==========================================
+ Coverage   85.86%   86.15%   +0.29%     
==========================================
  Files           5        5              
  Lines        1323     1351      +28     
==========================================
+ Hits         1136     1164      +28     
  Misses        187      187
Impacted Files Coverage Δ
src/lib.rs 88.19% <100%> (+0.64%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf7dca3...58fa5e7. Read the comment docs.

@thymbahutymba
Copy link
Author

I'm also wondering, do you want a PR that formats the code with rustfmt?

@thymbahutymba
Copy link
Author

I was thinking about to make more generic the from_vec method in such way

pub fn from_vec<T, E>(v: T) -> Self 
	where
		T: IntoIterator<Item = E>,
		E: TableElem,

I'm not an expert of Rust so I'm asking for your feedback because you may noctice some trouble that may appear in such cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant