Skip to content

Commit

Permalink
Bump to v6.6.4 (#1463)
Browse files Browse the repository at this point in the history
Some language changes were made to the CHANGELOG and comments,
to be more precise about the affected Gradle versions and how the
dependency file detection logic works.

Release-Version: v6.6.4
  • Loading branch information
maxrake authored Jun 27, 2024
1 parent 4509464 commit 3b858ae
Show file tree
Hide file tree
Showing 5 changed files with 13 additions and 10 deletions.
6 changes: 4 additions & 2 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,15 +8,17 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).

## Unreleased

## 6.6.4 - 2024-06-27

### Fixed

- Gradle 5 lockfiles not overriding manifest files in the same project
- Legacy Gradle lockfiles not overriding manifest files in the same project

## 6.6.3 - 2024-06-26

### Fixed

- Support for gradle lockfiles in `gradle/dependency-locks/`
- Support for legacy Gradle lockfiles in `gradle/dependency-locks/`

## 6.6.2 - 2024-06-25

Expand Down
2 changes: 1 addition & 1 deletion Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion cli/Cargo.toml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[package]
name = "phylum-cli"
version = "6.6.3"
version = "6.6.4"
authors = ["Phylum, Inc. <[email protected]>"]
license = "GPL-3.0-or-later"
edition = "2021"
Expand Down
6 changes: 3 additions & 3 deletions docs/lockfile_generation.md
Original file line number Diff line number Diff line change
Expand Up @@ -68,9 +68,9 @@ will automatically switch to `go.sum` if available. To override this, simply spe
analyze -t go go.mod`)
Second, without explicitly specifying dependency files, manifest files will only be used if there is no corresponding
lockfile in the same directory or any parent directory. For example, a single `Cargo.lock` file at the root of the
repository will be used instead of looking at any `Cargo.toml` files anywhere in the repository. To avoid this, run
`phylum init` and specify all files that you want analyzed.
lockfile. For example, a single `Cargo.lock` file at the root of the repository will be used instead of looking at any
`Cargo.toml` files anywhere in the repository. To avoid this, run `phylum init` and specify all files that you want
analyzed.
## Lockifests
Expand Down
7 changes: 4 additions & 3 deletions lockfile/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -362,7 +362,7 @@ impl DepFiles {
///
/// This will filter out manifests if there is a manifest or lockfile in a
/// directory above them. To get all lockfiles and manifests, see
/// [`LockableFiles::find_at`].
/// [`DepFiles::find_at`].
///
/// Paths excluded by gitignore are automatically ignored.
pub fn find_depfiles_at(root: impl AsRef<Path>) -> Vec<(PathBuf, LockfileFormat)> {
Expand All @@ -378,8 +378,9 @@ pub fn find_depfiles_at(root: impl AsRef<Path>) -> Vec<(PathBuf, LockfileFormat)
let mut lockfile_dirs =
depfiles.lockfiles.iter().filter_map(|(path, format)| Some((path.parent()?, format)));
remove |= lockfile_dirs.any(|(mut lockfile_dir, lockfile_format)| {
// Gradle 5 lockfiles are in a subdirectory, so we truncate these directories to
// get the effective directory these lockfiles were created for.
// Legacy Gradle (before v7) lockfiles are in a subdirectory,
// so we truncate these directories to get the effective
// directory these lockfiles were created for.
let dir_str = lockfile_dir.to_string_lossy();
if lockfile_format == &LockfileFormat::Gradle
&& dir_str.ends_with("/gradle/dependency-locks")
Expand Down

0 comments on commit 3b858ae

Please sign in to comment.