Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issues with cargo-update workflow #1244

Merged
merged 2 commits into from
Oct 2, 2023
Merged

Fix issues with cargo-update workflow #1244

merged 2 commits into from
Oct 2, 2023

Conversation

kylewillmon
Copy link
Contributor

This patch addresses many little issues:

  • The backtick (`) character was being interpreted as shell expansion in the git commit command
  • The noreply email for phylum-bot did not include the user ID
  • This repository does not use Conventional Commits, so the build: prefix was unnecessary

@kylewillmon
Fix issues with cargo-update workflow
5da68f7 
This patch addresses many little issues:

- The backtick (`) character was being interpreted as shell expansion in
  the `git commit` command
- The `noreply` email for `phylum-bot` did not include the user ID
- This repository does not use Conventional Commits, so the `build:`
  prefix was unnecessary
@kylewillmon kylewillmon requested a review from a team as a code owner October 2, 2023 15:52
maxrake
maxrake previously approved these changes Oct 2, 2023
View reviewed changes
Copy link
Contributor

@maxrake maxrake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

.github/workflows/cargo-update.yml Outdated Show resolved Hide resolved
maxrake
maxrake approved these changes Oct 2, 2023
View reviewed changes
Copy link
Contributor

@maxrake maxrake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kylewillmon kylewillmon merged commit 3300c62 into main Oct 2, 2023
15 checks passed
@kylewillmon kylewillmon deleted the bump-dep-workflow branch October 2, 2023 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cd-work cd-work cd-work approved these changes

@maxrake maxrake maxrake approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kylewillmon @maxrake @cd-work