Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify clap value_name case #1257

Merged
merged 2 commits into from
Oct 19, 2023
Merged

Unify clap value_name case #1257

merged 2 commits into from
Oct 19, 2023

Conversation

cd-work
Copy link
Contributor

@cd-work cd-work commented Oct 19, 2023

Previously the case for the value names of CLI arguments was mixed lower and upper case. Since the standard on unix systems is usually uppercase, all options have been changed to comply with this format.

Previously the case for the value names of CLI arguments was mixed lower
and upper case. Since the standard on unix systems is usually uppercase,
all options have been changed to comply with this format.
@cd-work cd-work requested a review from a team as a code owner October 19, 2023 20:40
@cd-work cd-work requested a review from maxrake October 19, 2023 20:40
@cd-work cd-work self-assigned this Oct 19, 2023
@cd-work cd-work requested review from kylewillmon and removed request for maxrake October 19, 2023 20:41
Copy link
Contributor

@maxrake maxrake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice change. The docs will likely also need to be updated.

Copy link
Contributor

@maxrake maxrake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cd-work cd-work merged commit 7777993 into main Oct 19, 2023
14 checks passed
@cd-work cd-work deleted the unify_value_names branch October 19, 2023 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants