Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary features from git2 dependency #1474

Merged
merged 1 commit into from
Jul 12, 2024
Merged

Remove unnecessary features from git2 dependency #1474

merged 1 commit into from
Jul 12, 2024

Conversation

cd-work
Copy link
Contributor

@cd-work cd-work commented Jul 12, 2024

No description provided.

@cd-work cd-work self-assigned this Jul 12, 2024
@cd-work cd-work requested a review from a team as a code owner July 12, 2024 18:53
@cd-work cd-work requested review from mathew-horner and kylewillmon and removed request for mathew-horner July 12, 2024 18:53
kylewillmon
kylewillmon approved these changes Jul 12, 2024
View reviewed changes
Copy link
Contributor

@kylewillmon kylewillmon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

maxrake
maxrake approved these changes Jul 12, 2024
View reviewed changes
Copy link
Contributor

@maxrake maxrake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The openssl-sys sub-dependency appears to be gone now. LGTM.

@cd-work
Copy link
Contributor Author

cd-work commented Jul 12, 2024

Just to be clear: The repository URL feature has been tested and still works (for now).

@cd-work cd-work enabled auto-merge (squash) July 12, 2024 18:56
@cd-work cd-work merged commit 74c3052 into main Jul 12, 2024
19 checks passed
@cd-work cd-work deleted the strip_git2 branch July 12, 2024 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxrake maxrake maxrake approved these changes

@kylewillmon kylewillmon kylewillmon approved these changes

Assignees

@cd-work cd-work

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cd-work @kylewillmon @maxrake