Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add windows binary to release #1486

Merged
merged 1 commit into from
Sep 3, 2024
Merged

Add windows binary to release #1486

merged 1 commit into from
Sep 3, 2024

Conversation

kylewillmon
Copy link
Contributor

This patch adds a windows executable to the release artifacts. This build does not include extensions or sandboxing, so I have left it unsigned and will not be recommending it as a first choice for Windows.

@kylewillmon kylewillmon requested a review from a team as a code owner August 30, 2024 16:57
@maxrake
Copy link
Contributor

maxrake commented Aug 30, 2024

This build does not include extensions or sandboxing, so I have left it unsigned and will not be recommending it as a first choice for Windows.

Are there other choices coming for Windows? Or, does this just mean the current suggestion for Windows installation (from the CLI Quickstart doc) will remain the first choice:

On Windows, we recommend using the Linux binaries under WSL

maxrake
maxrake previously approved these changes Aug 30, 2024
Copy link
Contributor

@maxrake maxrake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving for now in case time is of the essence, but there is a sugquestion that should still be addressed.

.github/workflows/release.yml Show resolved Hide resolved
Copy link
Contributor

@maxrake maxrake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kylewillmon kylewillmon merged commit be97f43 into main Sep 3, 2024
23 checks passed
@kylewillmon kylewillmon deleted the windows-release branch September 3, 2024 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants